Skip to content

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Jun 4, 2025

None of CI is using the unstable driver containers, the container driver build is private, and the script building it was failing for a long time and nobody noticed.

igc-dev doesn't use it either.

Just remove it.

@sarnex sarnex temporarily deployed to WindowsCILock June 4, 2025 18:00 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock June 4, 2025 18:30 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock June 4, 2025 18:30 — with GitHub Actions Inactive
Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex sarnex temporarily deployed to WindowsCILock June 4, 2025 19:16 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock June 4, 2025 20:00 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock June 4, 2025 20:00 — with GitHub Actions Inactive
@sarnex
Copy link
Contributor Author

sarnex commented Jun 4, 2025

CI fails not related.

@sarnex sarnex marked this pull request as ready for review June 4, 2025 20:21
@sarnex sarnex requested a review from a team as a code owner June 4, 2025 20:21
@sarnex
Copy link
Contributor Author

sarnex commented Jun 4, 2025

@jsji @YuriPlyakhin Do you guys remember why we added an unstable driver image? Just want to make sure we really don't need it. Thx.

@jsji
Copy link
Contributor

jsji commented Jun 4, 2025

@jsji @YuriPlyakhin Do you guys remember why we added an unstable driver image? Just want to make sure we really don't need it. Thx.

It was added before we added igc-dev, so I don't know why. I guess it was for some dev testing purpose only?

@bader
Copy link
Contributor

bader commented Jun 4, 2025

@sarnex, please, update https://github.com/intel/llvm/blob/sycl/sycl/doc/developer/DockerBKMs.md#ubuntu-2404-based-dockerfiles.

latest: Intel drivers are downloaded from release/tag and saved in dependencies.json. The drivers are tested/validated everytime we upgrade the driver.

unstable: Intel drivers are downloaded from release/latest.

I guess it was for some dev testing purpose only?

That's right. Despite the name sometimes the driver in the latest image is not the most recent available driver. latest driver must pass the testing (i.e. stable version of the driver).
The idea behind unstable is to provide access to the container with the most recent GPU driver regardless of SYCL validation status. It's useful to verify that certain regressions or bugs are fixed in the GPU driver. By definition this container is not supposed to be used by CI. If all tests pass, latest will have the same driver version.

@sarnex
Copy link
Contributor Author

sarnex commented Jun 4, 2025

@bader To be clear, are okay with this PR once I update the doc? It also removes the code that updates the container.

@bader
Copy link
Contributor

bader commented Jun 4, 2025

@bader To be clear, are okay with this PR once I update the doc? It also removes the code that updates the container.

If no one on the team uses unstable containers, I'm okay with the change.

Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex sarnex requested a review from a team as a code owner June 5, 2025 00:05
@sarnex sarnex temporarily deployed to WindowsCILock June 5, 2025 00:05 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock June 5, 2025 00:28 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock June 5, 2025 00:28 — with GitHub Actions Inactive
@sarnex sarnex requested a review from bader June 5, 2025 14:19
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sycl/doc/developer/DockerBKMs.md changes look good to me.

@sarnex
Copy link
Contributor Author

sarnex commented Jun 5, 2025

Thx
@aelovikov-intel Can you review the devops changes? Thx

# while we working to resolve the issue.
echo "Backup libopencl-clang"
cp -d /usr/local/lib/libopencl-clang2.so.14* .
cp -d /usr/local/lib/libopencl-clang2.so.15* .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I don't understand why we need this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah sorry its not technically related but since this fixes an error that was happening before we hit a new issue, the abi version of the latest igc dev packages is 15 so we need to update this part.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Sounds good!

@sarnex sarnex merged commit 58d681a into intel:sycl Jun 5, 2025
32 of 35 checks passed
@sarnex
Copy link
Contributor Author

sarnex commented Jun 5, 2025

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants