-
Notifications
You must be signed in to change notification settings - Fork 790
[CI][Devops] Remove unstable driver containers #18813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
CI fails not related. |
@jsji @YuriPlyakhin Do you guys remember why we added an unstable driver image? Just want to make sure we really don't need it. Thx. |
It was added before we added igc-dev, so I don't know why. I guess it was for some dev testing purpose only? |
@sarnex, please, update https://github.com/intel/llvm/blob/sycl/sycl/doc/developer/DockerBKMs.md#ubuntu-2404-based-dockerfiles.
That's right. Despite the name sometimes the driver in the |
@bader To be clear, are okay with this PR once I update the doc? It also removes the code that updates the container. |
If no one on the team uses |
Signed-off-by: Sarnie, Nick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sycl/doc/developer/DockerBKMs.md changes look good to me.
Thx |
# while we working to resolve the issue. | ||
echo "Backup libopencl-clang" | ||
cp -d /usr/local/lib/libopencl-clang2.so.14* . | ||
cp -d /usr/local/lib/libopencl-clang2.so.15* . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I don't understand why we need this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah sorry its not technically related but since this fixes an error that was happening before we hit a new issue, the abi version of the latest igc dev packages is 15
so we need to update this part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Sounds good!
Thx! |
None of CI is using the unstable driver containers, the container driver build is private, and the script building it was failing for a long time and nobody noticed.
igc-dev
doesn't use it either.Just remove it.